Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import user column type #12008

Merged
merged 17 commits into from
Oct 10, 2023
Merged

Import user column type #12008

merged 17 commits into from
Oct 10, 2023

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Oct 9, 2023 •
edited
Loading

Description

Allowing importing and exporting tables with column types

Screenshots

Creating a new internal table with CSV data

image

Importing a CSV into an existing internal table

image

Importing a CSV into an existing external table

image

@adrinr adrinr mentioned this pull request Oct 9, 2023
Merged
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #12008 (9a5dd71) into feature/multi-user-type-column (11a40ca) will decrease coverage by 1.51%.
Report is 2 commits behind head on feature/multi-user-type-column.
The diff coverage is 30.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@                        Coverage Diff                         @@
##           feature/multi-user-type-column   #12008      +/-   ##
==================================================================
- Coverage                           67.96%   66.45%   -1.51%     
==================================================================
  Files                                 585      490      -95     
  Lines                               21780    19673    -2107     
  Branches                             4376     4082     -294     
==================================================================
- Hits                                14802    13074    -1728     
+ Misses                               6456     6100     -356     
+ Partials                              522      499      -23
Files Coverage Δ
...ackages/server/src/api/controllers/row/internal.ts 85.15% <100.00%> (ø)
packages/server/src/api/controllers/table/index.ts 67.77% <100.00%> (ø)
...kages/server/src/api/controllers/table/internal.ts 78.94% <100.00%> (ø)
packages/server/src/api/controllers/table/utils.ts 68.58% <100.00%> (ø)
...src/utilities/rowProcessor/bbReferenceProcessor.ts 89.36% <ø> (ø)
...ackages/server/src/utilities/rowProcessor/index.ts 69.65% <100.00%> (+0.64%) ⬆️
...kages/server/src/api/controllers/view/exporters.ts 70.37% <50.00%> (-1.63%) ⬇️
packages/backend-core/src/docIds/ids.ts 30.76% <33.33%> (+0.21%) ⬆️
...kages/server/src/api/controllers/table/external.ts 77.77% <0.00%> (ø)
packages/server/src/utilities/schema.ts 26.95% <14.28%> (-8.18%) ⬇️

... and 95 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adrinr adrinr force-pushed the feature/import_user_column_type branch from ce05c13 to 5108d22 Compare October 10, 2023 11:53
@adrinr adrinr requested a review from mike12345567 October 10, 2023 12:22
mike12345567
mike12345567 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adrinr adrinr marked this pull request as ready for review October 10, 2023 12:40
mike12345567
mike12345567 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap - looks good - gets get it in!

@adrinr adrinr merged commit 097d3f1 into feature/multi-user-type-column Oct 10, 2023
@adrinr adrinr deleted the feature/import_user_column_type branch October 10, 2023 14:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mike12345567 mike12345567 mike12345567 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrinr @codecov-commenter @mike12345567